packaging
---------

- please remove DM-Upload-Allowed: yes.
  the procedure changed.
  > done

- full license check with at least licensecheck. Each file of the
  package should have the right copyright informations. (this is also
  why embedded libraries is a pain)
  > I double checked and found files in Cudd, which have unclear licenses. 
    We do not need them, so I removed them and added a Comment to
    debian/copyright. (Also removed upstream.)

- 0005_PolyGUI.patch was commited applyed into the master branch. It
  would be nice to use gbp-pq to produce the patch series.
  > The repo is now switched to gbp-pq (was git-gdm, but not consistently)

- deal with all remaining bugs from debbug
  > #636466 (Compatibility with ipython 0.11) is fixed in 0.8.2.

- replace Pre-Depends: multiarch-support by Pre-Depends:
  ${misc:Pre-Depends}
  > done

- add Multi-Arch: same where needed. libpolybori-0.8-2,
  libpolybori-groebner-0.8-2
  > done
  
- add Pre-Depends and Multi-Arch to -dev packages and also the -dbg
  one
  > done

- if ipbori could be replace by an ipython profile, maybe install this
  profile under python-polybori binary package and remove the polybori
  package.

  > This is not possible, since ipbori does more that a profile could do.
    For instance, it supports various versions of ipython, which the profile
    syntax just cannot do.

- check that the changelog is ok, 0.8-0, 0.8.2-1~exp0 and 0.8.2-1~exp1
  but I have no trace of those 0.8-0 and 0.8.2-1~exp0 into the Debian
  archive. So fix this by merging the three entries into only one.
  0.8.2-1~exp1 and target experimental instead of unstable

  > Indeed we did not mange to make those variants official, so all three
     entries are menged into one now. It's also "experimental" now.

- remove libpolybori-0.5.0-0.install from the repository
  (maybe this is just in my own repo ;)
  > done

- please use the same name for the symbol files and the the library one.
  libpolybori-0.8.symbols -> libpolybori-0.8-2.symbols
  idem for the other library.
  > done

- in the symbols files you use the wrong version number
   _Z10error_textP15pbori_DdManager@Base 0.8 this should be the
   package version (changelog) without the debian version. In your
   case 0.8.2
   > done 

- instread of
 override_dh_strip:
        dh_strip --exclude=groebner --exclude=PyPolyBoRi -plibpolybori-dev --dbg-package=libpolybori-dbg -a
        dh_strip --exclude=PyPolyBoRi -plibpolybori-groebner-dev  --dbg-package=libpolybori-groebner-dbg -a
        dh_strip -ppython-polybori -a

 can you use this
 override_dh_strip:
	dh_strip -plibpolybori-0.8-2 --dbg-package=libpolybori-0.8-2-dbg
	dh_strip -plibpolybori-groebner-0.8-2 --dbg-package=libpolybori-groebner-0.8-2-dbg
	dh_strip -a -Nlibpolybori-0.8-2 -Nlibpolybori-groebner-0.8-2

 this seems to me cleaner. (beware to use the right -dbg package name
 and change them in the control file).

 > done

- once done with the control file it would be very good to check with
  debian-l10n-english for it's correctness. You can send an email to
  this mailing list (I do not remember exactly the name but you can
  find it bu googling), asking for a review of your package (attach
  the control file and the git repository location). there is english
  natives which can help and improve a lot the description of the
  package. It helps me a lot before.
>>>>>>>>>> TODO
- Build-Depends: debhelper (>= 9),
               patchutils,
               scons,
               python-setuptools,
               libboost-dev,
               libboost-python-dev,
               doxygen,
               hevea | tex4ht,
               python-all-dev

 it seems to me that libboost-dev, patchutils are useless
  > patchutils removed, but we need more than just python bindings from boost.

 python-setuptools should be avoid if
 build-python%: PYTHONSITE=`/usr/bin/python$* -c 'import setuptools; print setuptools.distutils.sysconfig.get_python_lib() '`

 distutils where use instead
 build-python%: PYTHONSITE=`/usr/bin/python$* -c 'import distutils.sysconfig; print distutils.sysconfig.get_python_lib() '`

  > done
 
 you depends of hevea | tex4ht is it used by doxygen ?, if not you can remove it

  > no, we have a LaTeX-based tutorial, which is converted to html using
    one or the other

- your package provide a arch: all package.  it would be nice in that
  case to create an indep part like this one:

               #!/usr/bin/make -f
               %:
                       dh $@

               override_dh_auto_build-indep:
                       $(MAKE) -C docs

               # Aucun test nécessaire pour la documentation
               override_dh_auto_test-indep:

               override_dh_auto_install-indep:
                       $(MAKE) -C docs install

 this exemple is taken from the dh manpage. but in your case it seems
 that you need to avoid compiling the documentation from scons.  then
 you should create a Build-Dep-Indep: doxygen, hevea | tex4ht this is
 better when it comes to do binary NMU. the arch all part is not
 modified.

  >>>>>>>>> TODO


upstream
--------

- remove the embeded M4RI
  > This will be done, but first we need to figure out a convenient way how to 
    obtain libm4ri, if it is not available on the system.
  
- Cudd package or not package ?
  > no, we forked it, it's not compatible

- some part of the python code do not follow the pep8 recommendations.
  indented with 2 spaces instead of 4.
  > done (also patched into the package.)

- why not using QtDesigner instead of hard coding the ui part ?
  > when it's getting more complex. Now it's just a small python script.

- ipbori can be an ipython profile instead of a dedicated binary ?
  > no (see above)

- integrate the .desktop file in the upstream installation process.
  this way it can be usefull to other distributions.
  > done

- rename polybori.pc into polybori-0.8.pc this is much more consistant
  with the current naming schema. idem for the other library.

  > done

- maybe add an option for the documentation compilation only.

 >>>>>>>>> TODO
  > First, we have to separate the python modules documentation 
    (not platform independend) from the doxygen/LaTeX-based stuff.
    I'm also not sure whther the doxygen-based stuff in platform independent,
    since it also analyzes polybori/config.h